[FFmpeg-devel] [PATCH] fix for roundup issue 2471

Aurelien Jacobs aurel
Tue Jan 4 00:33:18 CET 2011


On Mon, Jan 03, 2011 at 03:04:38AM +0100, Michael Niedermayer wrote:
> On Sun, Jan 02, 2011 at 11:55:25PM +0100, Aurelien Jacobs wrote:
> > On Sat, Jan 01, 2011 at 03:26:15PM -0500, Daniel Kang wrote:
> > > I am a Google Code-In student and as part of a task, I have used zzuf to
> > > generate a file that crashes ffmpeg. The issue is caused by invalid mkv
> > > timestamps.
> > > 
> > > The patch attached fixes roundup issue 2471. It adds a sanity check
> > > before incrementing the timestamp.
> > 
> > I don't think it's the proper place to fix this issue.
> > Attached patch should fix the root of this issue.
> > 
> > Currently, the mpeg4video decoder corretly detects when time_base.den is
> > null and error out, but it leaves time_base.num with it's non-null
> > value. My patch just reset time_base.num to 0 before erroring out.
> > 
> > Aurel
> >  mpeg4videodec.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 57a9c667c1692e51a7dc69fbdf917967f09f7027  m4vdec_issue2471.diff
> 
> thats a possible fix yes, ok with me if tested

Yes, tested and applied.

Aurel



More information about the ffmpeg-devel mailing list