[FFmpeg-devel] [PATCH] fix for roundup issue 2475

Daniel Kang daniel.d.kang
Tue Jan 4 06:29:00 CET 2011

On Sun, Jan 2, 2011 at 12:34 AM, Daniel Kang <daniel.d.kang at gmail.com>wrote:

> I am a Google Code-In student, and as part of a task, I have used zzuf
> to generate a wav file that causes ffmpeg to fail an assertion. The
> roundup issue is 2475. The error occurs when invalid sampling rates
> (i.e. negative ones) fail the assertion.
> I have attached a patch that adds a sanity check on sampling rates. It
> should also work for other audio types, but I could not generate a file
> that fails with the same error. Are there any comments?

I have uploaded a third sample that fails the assertion. It seems as
though my patch works for audio files in general, as compute_frame_rate
is a general function. Since I have not had any comments, is this
solution acceptable?

More information about the ffmpeg-devel mailing list