[FFmpeg-devel] [patch] allow wordexp globs in image2 file sequence import

Brian Olson icic
Tue Jan 4 14:47:21 CET 2011

On Jan 3, 2011, at 6:22 PM, Aurelien Jacobs wrote:

> This looks wrong. This won't detect expressions such as "pict*.jpeg".
> And it would look cleaner without #if:
> static int is_wordexp(const char* path) {
>    return HAVE_WORDEXP && strcspn(path, "*?[](){}\\") != strlen(path);
> }

Yeah, that was me trying to be clever and simplify and instead misusing the string.h function that was new to me. I had run into that eventually in my own testing but hadn't posted the fix yet. Updated patch attached now.

Brian Olson

-------------- next part --------------
A non-text attachment was scrubbed...
Name: img2_wordexp_20110104.diff
Type: application/octet-stream
Size: 5359 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110104/8e4aabd6/attachment.obj>
-------------- next part --------------

More information about the ffmpeg-devel mailing list