[FFmpeg-devel] [PATCH] Fix ljpegenc pix_fmt selection

Jason Garrett-Glaser jason
Tue Jan 4 19:21:15 CET 2011


On Tue, Jan 4, 2011 at 1:18 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Jan 02, 2011 at 12:58:30PM -0500, Jason Garrett-Glaser wrote:
>> Previously, if you didn't happen to select the right pix_fmt via
>> pix_fmt, ffmpeg would fail to convert to the pixel formats supported
>> by ljpeg.
>>
>> Jason
>
>> Index: libavcodec/ljpegenc.c
>> ===================================================================
>> --- libavcodec/ljpegenc.c ? ? (revision 26200)
>> +++ libavcodec/ljpegenc.c ? ? (working copy)
>> @@ -194,5 +194,6 @@
>> ? ? ?MPV_encode_init,
>> ? ? ?encode_picture_lossless,
>> ? ? ?MPV_encode_end,
>> + ? ?.pix_fmts= (const enum PixelFormat[]){PIX_FMT_YUVJ420P, PIX_FMT_YUVJ422P, PIX_FMT_BGRA, PIX_FMT_NONE},
>> ? ? ?.long_name = NULL_IF_CONFIG_SMALL("Lossless JPEG"),
>> ?};
>
> that seems not correct
> if i remove all the pix fmt tests yuv444p works too for example

Yeah, but that should go in a separate patch.  This patch is just to
fix the current situation: revising the pixfmt checks in mpegvideo is
an unrelated problem.

Jason



More information about the ffmpeg-devel mailing list