[FFmpeg-devel] [PATCH] fix for invalid creation time crash (roundup issue 2490)

Daniel Kang daniel.d.kang
Wed Jan 5 05:46:51 CET 2011


I am a Google Code-In student, and as part of a task, I have used zzuf
to generate a mov file with an invalid creation time. This causes ffmpeg
to crash. gmtime is called, and when it cannot convert the time, it
returns NULL. Then, strftime is called with a NULL pointer and
segfaults. The roundup issue is 2490. I have attached a patch to fix
this. The patch adds a sanity check for NULL pointers. Are there any
comments?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mov_fix.diff
Type: application/octet-stream
Size: 968 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110104/00f9a707/attachment.obj>



More information about the ffmpeg-devel mailing list