[FFmpeg-devel] [PATCH] fix for roundup issue 2475

Reimar Döffinger Reimar.Doeffinger
Wed Jan 5 17:23:19 CET 2011


On Tue, Jan 04, 2011 at 03:12:41PM -0500, Daniel Kang wrote:
> On Tue, Jan 4, 2011 at 4:02 AM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de>wrote:
> 
> >  I think it would still set invalid values if e.g. one is 1 and the other
> > is 0.
> > The condition should possibly be both > 0 or both 0.
> >
> 
> I have updated the patch so that the condition to break (error out)
> is <= 0.

Well, I don't know what the intention was, but previously the code for a
value of 0/0 would explicitly set that as indicating "invalid".
I think that your patch probably is correct, but I don't know for sure.



More information about the ffmpeg-devel mailing list