[FFmpeg-devel] [PATCH] Fix a couple of errors with bad Vorbis headers

Frank Barchard fbarchard
Thu Jan 6 03:29:27 CET 2011


On Wed, Dec 29, 2010 at 12:32 AM, Gregory Maxwell <greg at xiph.org> wrote:

> On Tue, Dec 28, 2010 at 11:19 PM, Alex Converse <alex.converse at gmail.com>
> wrote:
> > Patch by Chris Evans/Google Chrome
> >
> > Chrome review URL:
> > http://codereview.chromiumcodereview.org/5964011<
> http://codereview.chromium.org/5964011>
> > Chrome bug URL:
> > http://code.google.com/p/chromium/issues/detail?id=68815(Broken?)
>
> I was going to test this patch to validate that it doesn't break any
> regular files, but I found that a current ffmpeg git checkout
> (3f9de618) doesn't play all the files in the public test vectors:
>
>
> http://people.xiph.org/~xiphmont/test-vectors/vorbis/one-entry-codebook-test.ogg
> http://people.xiph.org/~xiphmont/test-vectors/vorbis/test-short.ogg
>
> are both falsely rejected.
>

These are rejected both before and after the patch, and I went back to an
old r22888 and that also rejected them.
So its not a regression and should be handled. if necessary, in another
patch.



More information about the ffmpeg-devel mailing list