[FFmpeg-devel] [PATCH] check for invalid decode type with interplay videos (issue 2522)

Michael Niedermayer michaelni
Mon Jan 10 03:12:33 CET 2011

On Sun, Jan 09, 2011 at 06:30:29PM -0500, Daniel Kang wrote:
> When ffmpeg attempts to decode an interplay video with an invalid decode
> opcode, ffmpeg crashes in certain cases. The attached patch adds a check
> for this.

>  interplayvideo.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 0b8f5c7a9509c21e9c497a79896990fd5082d206  mve_invalid_decode_check.diff
> From 6ea4633f0759d87f3af70ee404a6b1ddb6f748d5 Mon Sep 17 00:00:00 2001
> From: Daniel Kang <daniel.d.kang at gmail.com>
> Date: Sun, 9 Jan 2011 18:14:44 -0500
> Subject: [PATCH] Check for interplay video invalid decode type

Its not all that pretty to check this in there (would be nicer if we knew
earlier if the last frame was needed instead of checking in the inner loops)

but given this is a fringe codec iam ok with this any other solution would be
quite a bit more complex and more obfuscated

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110110/4ebc5894/attachment.pgp>

More information about the ffmpeg-devel mailing list