[FFmpeg-devel] [PATCH] Re: How can I determine color_range from a filter?

Larry Robinson silver-dad
Mon Jan 10 19:11:45 CET 2011


On 1/10/2011 6:52 AM, Michael Niedermayer wrote:
> On Sun, Jan 09, 2011 at 09:20:21PM -0800, Larry Robinson wrote:
>> On 1/9/2011 2:30 PM, Michael Niedermayer wrote:
>>> On Sun, Jan 09, 2011 at 08:26:25PM +0100, Stefano Sabatini wrote:
>>>> On date Sunday 2011-01-09 19:42:27 +0100, Michael Niedermayer encoded:
>>>>> On Sun, Jan 09, 2011 at 12:11:02AM +0100, Stefano Sabatini wrote:
>>>>>> On date Friday 2011-01-07 11:12:59 -0800, Larry Robinson encoded:
> [...]
>>>> compile/install libavfilter without installing libavcodec (configure
>>>> --enable-libavfilter --disable-libavcodec),
>>> no problem here
>>>
>>>
>>>> in a distro you could have
>>>> libavfilter-dev and yet not libavcodec-dev.
>>> it wouldnt work, we dont have 4 independant configure scripts, and
>>> quadruplicating the build system across 5 split -dev packages seems like a
>>> bad idea
>>> and if you meant the distro simply physically removd libavcodec.
>>> We should nozt support this castration and if someone still wanted he can
>>> leave the header there as well if he already manually cuts things randomly
>>> away
>>>
> [...]
>> #ifndef AVCORE_COLORSPACE_H
>> #define AVCORE_COLORSPACE_H
> The enums are not just colorspace related some enums are related to the
> positions of samples.
> if at all this could be moved into teh main public header of avcore
>
> [...]
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
Alrightie then...
In the interest of progress, please allow me to sidestep this question 
(and the opt.h question) as follows:

1) For now, I will include avcodec.h in avfilter.h; if the color 
rendering enums are moved out, only this line would need to be changed.

2) I will encode color_primaries, etc. into the `args' string currently 
being passed to the vsrc_buffer init routine, which will now expect 10 
colon-separated arguments rather than 5.  This affects only the `buffer' 
filter.

I think there is agreement to place the 5 enums into the AVFilterLink 
structure.

If everyone agrees with this I can proceed.
Larry Robinson




More information about the ffmpeg-devel mailing list