[FFmpeg-devel] [PATCH] check for invalid sym values in indeo decoder (issue 2523)

Kostya kostya.shishkov
Wed Jan 12 07:43:47 CET 2011


On Tue, Jan 11, 2011 at 05:00:55PM -0500, Daniel Kang wrote:
> On Tue, Jan 11, 2011 at 4:21 PM, Kostya <kostya.shishkov at gmail.com> wrote:
> 
> > On Tue, Jan 11, 2011 at 03:26:19PM -0500, Daniel Kang wrote:
> > > On Tue, Jan 11, 2011 at 11:24 AM, Michael Niedermayer <michaelni at gmx.at
> > >wrote:
> > >
> > [...]
> > > >
> > > > this is a error condition and continuing with undefined values makes no
> > > > sense
> > > > also i suspect only one of teh 2 checks is needed
> > >
> > >
> > > I have updated the message and return an error. The invalid sym in this
> > > case are -1. I am not sure if the other check is needed, as the sample
> > > file does not encounter values greater than 256.
> >
> > else{} is not needed there, just move assignment under the check
> 
> 
> Patch updated without the else.

looks ok



More information about the ffmpeg-devel mailing list