[FFmpeg-devel] [PATCH] libmpcodecs support

Michael Niedermayer michaelni
Fri Jan 14 14:14:12 CET 2011

On Fri, Jan 14, 2011 at 08:00:58AM -0500, compn wrote:
> On Fri, 14 Jan 2011 05:37:45 +0100, Michael Niedermayer wrote:
> >
> >Hi
> >
> >Attached patchset makes libavfilter support most libmpcodecs filters
> >The libmpcodecs filters are practically unmodified and for keeping it
> >maintainable id like to keep them unmodified.
> \o/
> well done. after months and months and months of everyone refusing to
> make a wrapper. you've done it! :)

in less than 3 days to add, i thought it would be harder ...

> >I will commit this soon but wont enable it yet. That way others can help
> >cleanup the wraper (minus code that for maintainability should stay identical
> >to the original), fix bugs, rename all global functions so they wont conflict
> >with mplayers if they ever include this and generally help.
> >
> >Please dont bikeshed this to death.
> >
> >Ahh before i can commit this, libmpcodecs and subdirectories must not get
> >blocked by the tab & trailing whitespace checkin scripts.
> i think its ok? to remove tabs and trailing whitespace in
> mplayer first. unless you wanted to keep history?

I dont really care, mplayer history has been messed up with cosmetics already
enough to make it pretty useless
just as example the m_option/m_struct code albeu added to filters would make
them depend on many more (unrelated) headers in mplayer. It should have been a
matter of reverting these commits but they didnt apply due to lots of cleanup
by diego done afterwards. I had to apply them by hand as no single hunk applied
automatically no matter what options i fed into patch

> >+    .description = NULL_IF_CONFIG_SMALL("libmpcodecs wraper."),
> wrapper :)

i just tried to make the patch smaller ;)
updated locally though

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110114/e61d0874/attachment.pgp>

More information about the ffmpeg-devel mailing list