[FFmpeg-devel] [PATCH] libmpcodecs support

Michael Niedermayer michaelni
Fri Jan 14 20:57:57 CET 2011

On Fri, Jan 14, 2011 at 11:45:48AM -0800, Baptiste Coudurier wrote:
> Hi Michael,
> On 01/13/2011 08:37 PM, Michael Niedermayer wrote:
>> Hi
>> Attached patchset makes libavfilter support most libmpcodecs filters
>> The libmpcodecs filters are practically unmodified and for keeping it
>> maintainable id like to keep them unmodified.
>> I will commit this soon but wont enable it yet. That way others can help
>> cleanup the wraper (minus code that for maintainability should stay identical
>> to the original), fix bugs, rename all global functions so they wont conflict
>> with mplayers if they ever include this and generally help.
>> Please dont bikeshed this to death.
>> Ahh before i can commit this, libmpcodecs and subdirectories must not get
>> blocked by the tab&  trailing whitespace checkin scripts.
>> [...]
>>  From fcd1ad739d7c36473813ee0d9c495a57bf2df268 Mon Sep 17 00:00:00 2001
>> From: Michael Niedermayer<michaelni at gmx.at>
>> Date: Fri, 14 Jan 2011 05:06:30 +0100
>> Subject: [PATCH 6/7] Add libmpcodecs wraper for libavfilter, still disabled
>> ---
>>   libavfilter/vf_mp.c |  913 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>   1 files changed, 913 insertions(+), 0 deletions(-)
>>   create mode 100644 libavfilter/vf_mp.c
>> diff --git a/libavfilter/vf_mp.c b/libavfilter/vf_mp.c
> The other filters may be kept intact, but the libavfilter wrapper should  
> be reformatted and cleaned up.

Iam undecided about that a bit, i really dont like how it looks either.
The problem is that the code in the wrapper is to a large extend based and in
some cases exactly copied from libmpcodecs/vf.c
so iam not sure what to do. Its easier to maintain if the copied/based code
stays formated like the original

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110114/393ef48e/attachment.pgp>

More information about the ffmpeg-devel mailing list