[FFmpeg-devel] [PATCH] libmpcodecs support

Michael Niedermayer michaelni
Sat Jan 15 12:25:12 CET 2011

On Sat, Jan 15, 2011 at 03:17:24AM +0100, Luca Barbato wrote:
> On 1/14/11 3:19 PM, Michael Niedermayer wrote:
>> i can just merge the changes in, but IMHO if it takes you more than a few days
>> to run indent or sed over the code and get it approved then waiting longer has
>> zero sense. Because indent takes seconds, and getting it approved either will
>> happen or will not happen. And its twice as much code than there is in swcale so
>> doing anything by hand is (from experience of swscale) something taking years
>> and i think we all agree that blocking 80% of functionality of libavfilter
>> for years is not worth the style changes to code that is semantically not even
>> part of ffmpeg.
> I'd rather have clean and maintainable code in ffmpeg. I could accept  
> this kind of devils deal only if it gets first a full regression test so  
> trying to clean it up later would be half of the work.

dont forget the full regression test for swscale as condition to your
cleanup there

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110115/f40c9bd0/attachment.pgp>

More information about the ffmpeg-devel mailing list