[FFmpeg-devel] [PATCH] Clip-Wrapped MXF support (attempt #4)
Sat Jan 15 13:13:47 CET 2011
On Fri, Jan 14, 2011 at 10:14:27AM +0200, Maksym Veremeyenko wrote:
> >But unless the specification actually _requires_ a complete index (which
> >means it requires an index at all, and it requires that also each non-keyframe
> >has an index entry) that is a solution that only works with "good luck", not
> First i am not sure that Clip-Wrapped files with
> not-fixed-frames-size-content exists in real world - anyway we could
> always test them and fix behavior of demuxer...
Have you tried MPEG-2 clip-wrapped (both audio and video) files?
If your code is correct, you should be able to remove the
st->need_parsing = AVSTREAM_PARSE_FULL;
and it should still play. But I very much doubt it.
> >Does this code actually fix any case other that DV video? Because for DV it could be
> >considered the real bug that the raw DV demuxer was not implemented using a parser
> >(if it was, clip-wrapped DV should already work I think).
> Hope it does not /fix/ anything other :-))) at least i did not noticed...
That makes it likely that your patch _only_ works for DV, and the question is
what the point is of all the extra code that fiddles with the values to fix
them up for audio etc. when it works just as well without (e.g. enabling
this new code only for DV, or at least only when the edit unit is sensible
and we have no parser for the format).
More information about the ffmpeg-devel