[FFmpeg-devel] [PATCH] libmpcodecs support
Sat Jan 15 16:44:08 CET 2011
On 1/15/11 5:30 AM, Michael Niedermayer wrote:
> About regression tests, the idea is not bad if someone wants to do it. But
> Asking to do that (unrelated) work as condition for this patch feels a bit
> offensive IMHO. Ive not seen others make unrelated requests since a long time
> and i have even asked for help many times and there are
> important issues id like to work on like the malloc/free speed issue.
I think we are probably misunderstanding your purpose for this wrapper.
If The idea is to have it to ease the porting to libavfilter I think
makes sense keep it in a separate branch and not work on it if you think
we can't get that code clean enough to be merged as libavfilter.
I, and probably others, considered that as a quick route to give
features to our users. And reacted on this idea. Having had experience
with swscale peculiarities I'm more than wary about such imports.
> I prefered the past where comments where based on technical issues and not
> philosophical ones. And where maintainers could work on their code without
> everyone bikesheding every change.
If you think that is useful have it on master and we can make clear that
this code will disappear it could stay for that time. But I will have it
removed within this year at most (an hard limit helps avoiding eternal
temporary solutions) and have it depend on flag experimental so it would
not crawl to our userbase that easily.
I hope that helps clear why I'm this against this code import.
More information about the ffmpeg-devel