[FFmpeg-devel] [PATCH] libmpcodecs support
Sat Jan 15 20:56:47 CET 2011
On Sat, Jan 15, 2011 at 02:04:37PM +0100, Michael Niedermayer wrote:
> On Sat, Jan 15, 2011 at 01:01:23PM +0100, Reimar D?ffinger wrote:
> > On Fri, Jan 14, 2011 at 07:49:56PM +0100, Michael Niedermayer wrote:
> > > anyway if there are constructive suggestions left i very much would like to
> > > hear them if not id like to apply this, and if people want with tabs removed
> > > and reindented but later requires this to be approved by reimar and also
> > > reindented in mplayer svn
> > Anyone may feel free to do reindentation on libmpcodecs.
> > Though it might be good to talk to Diego, he had reindentation plans for
> > MPlayer for a long time and maybe he can just do what he had planned.
> > Would also make libmpcodecs serve as a test case for this.
> What i need to know is when people are done and there _certainly_ will be no
> further cosmetic changes to libmpcodecs.
> At this point then i can update this patchset and commit.
> Also we can either commit now and update once the cosmetics are done in mplayer
> or wait until they are done before commiting anything.
> The choice depends on how long this unneeded cosmetic cleanup will take
> I prefer to commit now and update things once the cosmetics are done
> Also id like to point out that all this is causing me alot of extra work and
> thats not fixng bugs and not adding features but useless bikeshed.
Please do not complain to me, I just wanted to help resolving the objections.
My idea in principle was that Diego has a fairly nice config for some indent-like
(but hopefully less buggy) tool, and if you ran it over MPlayer's libmpcodecs
and your modifications hopefully you'd have almost no extra work, code that
others don't complain that much anymore (and got rid of tabs in the process) and
libmpcodecs and the FFmpeg copy being in sync.
I'm also fine if you (or someone else) would just like to remove the tabs.
We can also avoid cosmetic changes to libmpcodecs and/or discuss them with you
first, if that is what you want.
More information about the ffmpeg-devel