[FFmpeg-devel] [PATCH] libmpcodecs support
Sun Jan 16 00:15:03 CET 2011
On Sat, Jan 15, 2011 at 11:23:23PM +0100, Reimar D?ffinger wrote:
> On Sat, Jan 15, 2011 at 11:10:36PM +0100, Michael Niedermayer wrote:
> > On Sat, Jan 15, 2011 at 09:01:42PM +0100, Reimar D?ffinger wrote:
> > > > i see nothing unpredictable on it
> > >
> > > Let me explain: hue adjustments could be done for free for yuv<->rgb conversions.
> > > This combined with above approach means that the results of the VFCTRL_SET_EQUALIZER will
> > > mean that if you have
> > > -vf swapuv
> > > the behaviour off hue adjustment will be completely different for a RGB vs. a YUV
> > > codec because for RGB you have the filters
> > > scale(convert to yuv), swapuv, output
> > > here hue adjustement would be done in scale, before swapuv.
> > > With YUV input you'd only have
> > > swapuv, output
> > > and thus hue would be adjusted in output, i.e. after swapuv.
> > yes but where is the difference between mplayer-libmpcodec and ffplay-libavfilter
> > here?
> > you said "for libavfilter that approach is likely too unpredictable though."
> That libavfilter is supposed to be more general.
> I realize that I forgot that it is possible to send a VFCTRL to a specific
> filter if you know you want to change exactly that one.
> Still, since libavfilter is a reimplementation thinking of a design that
> allows avoiding this issue would make sense I'd say.
To me the mplayer system seems quite solid and simple
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel