[FFmpeg-devel] [PATCH] libmpcodecs support

Stefano Sabatini stefano.sabatini-lala
Sun Jan 16 04:21:32 CET 2011


On date Sunday 2011-01-16 02:11:04 +0100, Luca Barbato encoded:
> On 1/16/11 1:45 AM, Michael Niedermayer wrote:
> >Diego, ping! you are in CC
> >i suggest we leave it at the tab removial and continue as soon as luca and
> >ronald agree.
> >comments?
> >a lack of a comment within 48h i will interpret as approval though would
> >prefer an explicit ok from you.
> 
> I still think the best for this is having a topic branch made public.

I tend to be against having multiple branches, as this get things very
complicated for users, and partly for developers. And, if the features
are not implemented in the main repo, users will simply don't use it,
at least most of them (indeed most users apparently still miss the
existence of the gsoc libavfilter repo, although it is advertised on
the libavfilter.html page).

Also, do you honestly think that having delayed the libswscale
integration into FFmpeg would have helped either FFmpeg or libswscale?
libswscale was a bloody mess, and still it is, but it would have been
even worse if it was not integrated into the main FFmpeg, and what's
even worse we and our users wouldn't have had all the features that
libswscale allows.

And note that the libmpcodecs wrapper case is a little different, as
it is not integrated into the ff* tools neither in the libraries, but
it's just a libavfilter module, and is not going to touch the FFmpeg
core, so I don't think it is "dangerous" to include it.

But I'm mildly in favor of keeping the imported libmpcodecs code
experimental, that is to disable its compilation by default, so that
users get aware that they can't rely on its stability.

Avoiding tabs should be done, as we shouldn't disallow SVN rules just
for this commit, but it should be done with the less possible burden
on who is doing the work, at this point I consider libmpcodecs dead
code so I think that spending too much work on it is worthless so an
automatic tab-removal script is perfectly enough.

Final note, I have already something like 40 branches in my local
repo, so I don't like the idea to work on more external repos and
synch and merge back and forward, having all the goods in the main
repo is an incentive for me to work on them, or I'll just don't care.

And having it in the main repo means more users -> more testers ->
more contributions -> more money&glory -> world domination, which I
remember is our final goal ;-).
-- 
FFmpeg = Fast & Freak Mythic Peaceful Evanescent Genius



More information about the ffmpeg-devel mailing list