[FFmpeg-devel] [PATCH] libmpcodecs support

Diego Biurrun diego
Sun Jan 16 20:12:33 CET 2011


On Sun, Jan 16, 2011 at 05:32:45PM +0100, Reimar D?ffinger wrote:
> On Sun, Jan 16, 2011 at 05:15:10PM +0100, Diego Biurrun wrote:
> > On Sun, Jan 16, 2011 at 04:23:44PM +0100, Reimar D?ffinger wrote:
> > > On Sun, Jan 16, 2011 at 03:53:52PM +0100, Diego Biurrun wrote:
> > > > I also see that Carl Eugen just committed the tab removal that directly
> > > > conflicts with my uncrustify work without any previous discussion, even
> > > > though Reimar mentioned that I am working on something related.
> > > 
> > > I have to say I didn't expect there to be any conflict, while suboptimal
> > > with concern to history, does this kind of change cause issues for your
> > > work?
> > 
> > It does not cause direct issues for my work, but Carl Eugen could not know
> > that.  The least thing he could do is ask, in the appropriate forum.  On
> > top of that I remember him being against cosmetic changes in the past.
> > 
> > Then there is the issue of bloating the history with huge and completely
> > pointless commits and causing conflicts for every single developer with
> > changes in one of the affected files.
> 
> I agree it wasn't optimal, and I don't disagree that you are justified
> to complain. I just see the agressiveness as neither helping not justified.

It surely is not helping, maybe it is not even justified, but maybe it
is at least somewhat understandable.  Carl Eugen and Michael have neither
forgiven nor forgotten what happened almost four years ago, on the
contrary, I get reminded at every possible occasion.

So forgive me if I get triggered more than I should, but from my point of
view it looks like just the kind of behavior they were so critical of,
only now it's OK because, well, no reason comes to mind except applying
different rules to different people.

So this is inconsistent behavior, to put it mildly, from my point of view
and I get triggered more than I should.  But it's not like the other side
has ever done anything to pour oil on troubled water, it was always poured
on the fire.

I will shut up now and don't mention it again, but I just had to state
my side of the matter.

> > How this kind of unannounced change can suddenly be taken for granted
> > without discussion just boggles my mind.  Had somebody else done it in
> > a different context, I'm sure the mob would already be calling for
> > accounts to be closed.
> 
> Honestly I think that's mostly because "the mob" has gone or become tired.
> I never considered closing an account as anything other than either an
> emergency reaction or after you just see no way of discussing with anyone
> reasonable.
> And I just can't imagine that you and Carl Eugen can't come to an agreement
> concerning this, he already said he will revert it if asked,

Note that he said he would revert if you asked, not if asked.

> and he wasn't really aware of your work, and I gave my ok before
> mentioning what you are working on, and I did not CC you or the
> MPlayer list (I thought about it, but I assumed that the discussion
> would go on for a while before anything was going to happen and thus
> it should not be necessary, my fault).

OK, but I don't think it's your fault that this premature commit caught
you by surprise.

Diego



More information about the ffmpeg-devel mailing list