[FFmpeg-devel] [PATCH 2/7] Factorize FAST_BGR2YV12

Luca Barbato lu_zero
Thu Jan 20 00:46:21 CET 2011


It is used only for x86 so it will be moved once the code is moved in
the arch dir

Question: should we build an accurate BGR2YV12 variant?
---
 libswscale/rgb2rgb.c          |    2 --
 libswscale/swscale.c          |    2 --
 libswscale/swscale_internal.h |    2 ++
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/libswscale/rgb2rgb.c b/libswscale/rgb2rgb.c
index 059bdab..21ccbd3 100644
--- a/libswscale/rgb2rgb.c
+++ b/libswscale/rgb2rgb.c
@@ -30,8 +30,6 @@
 #include "swscale.h"
 #include "swscale_internal.h"
 
-#define FAST_BGR2YV12 // use 7-bit instead of 15-bit coefficients
-
 #if ARCH_X86
 DECLARE_ASM_CONST(8, uint64_t, mmx_ff)       = 0x00000000000000FFULL;
 DECLARE_ASM_CONST(8, uint64_t, mmx_null)     = 0x0000000000000000ULL;
diff --git a/libswscale/swscale.c b/libswscale/swscale.c
index 375171f..d3eb5b5 100644
--- a/libswscale/swscale.c
+++ b/libswscale/swscale.c
@@ -76,8 +76,6 @@ untested special converters
 //#undef ARCH_X86
 #define DITHER1XBPP
 
-#define FAST_BGR2YV12 // use 7 bit coefficients instead of 15 bit
-
 #define isPacked(x)         (       \
            (x)==PIX_FMT_PAL8        \
         || (x)==PIX_FMT_YUYV422     \
diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h
index 19dff8f..910f300 100644
--- a/libswscale/swscale_internal.h
+++ b/libswscale/swscale_internal.h
@@ -31,6 +31,8 @@
 
 #define STR(s)         AV_TOSTRING(s) //AV_STRINGIFY is too long
 
+#define FAST_BGR2YV12 //use 7-bit instead of 15-bit coefficients
+
 #define MAX_FILTER_SIZE 256
 
 #if ARCH_X86
-- 
1.7.2.2




More information about the ffmpeg-devel mailing list