[FFmpeg-devel] [PATCH 1/3] Move lpc_compute_autocorr() from DSPContext to a new struct LPCContext.

Måns Rullgård mans
Fri Jan 21 03:31:06 CET 2011


Luca Barbato <lu_zero at gentoo.org> writes:

> On 01/21/2011 02:03 AM, Michael Niedermayer wrote:
>> Dont you think that the code that contains these offsets would
>> benefit more from cleanup to not break when random structs change
>> than regularly waiting for failure and then find someone with an
>> ARM build env to fix?
>
> It had been discussed a bit in the past. There isn't a portable way to
> get those offsets automatically given the field of use (arm is mostly
> cross-built, more than often with exotic toolchain).

A different approach would be to group the handful of field into a
sub-struct and pass a pointer to that instead of the MpegEncContext
pointer.  However, given the general appearance of MpegEncContext,
doing this can seem a bit scary.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list