[FFmpeg-devel] [PATCH] oggdec: do not set time_base to invalid value

Ronald S. Bultje rsbultje
Fri Jan 21 03:53:35 CET 2011


On Thu, Jan 20, 2011 at 5:38 PM, M?ns Rullg?rd <mans at mansr.com> wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>> Hello,
>> possible we should consider catching this at a higher level, and possibly
>> st->codec->sample_rate should not be assigned an invalid value either...
>> Vorbis ogg parser may set st->time_base.den to 0, causing an
>> assertion failure in av_rescale_* during av_update_stream_timings.
> This is a recurring theme. ?It needs to be addressed in a better way.

I thought Daniel Kang had submitted a patch that does this globally,
so formats don't have to do it per-format?  Why does that fail to
catch this case and error out properly?


More information about the ffmpeg-devel mailing list