[FFmpeg-devel] [PATCH 07/11] Make denoise_dct_c and dct_quantize_trellis_c static.

Diego Biurrun diego
Tue Jan 25 02:01:56 CET 2011

On Tue, Jan 25, 2011 at 01:57:10AM +0100, Diego Elio Petten? wrote:
> Il giorno mar, 25/01/2011 alle 01.47 +0100, Diego Biurrun ha scritto:
> > I don't see you making the functions themselves static, which seems
> > wrong. 
> The static declaration should be enough for the compiler, and it is
> here:
> % nm libavcodec/mpegvideo_enc.o| grep denoise_   
> 0000000000000a80 t denoise_dct_c
> But if you wish to make it more explicit, I'll send a patch.

I would prefer that, I find the static forward declaration and the
non-static definition confusing.


More information about the ffmpeg-devel mailing list