[FFmpeg-devel] [PATCH] Make denoise_dct_c() and dct_quantize_trellis_c() static in definitions

Diego Biurrun diego
Tue Jan 25 02:08:31 CET 2011


On Tue, Jan 25, 2011 at 01:02:41AM +0000, Mans Rullgard wrote:
> 1d4da6a460d5b78026e3b854fdd6f469957a054c added static to the
> prototypes for these fuctions.  Adding it to the definitions
> as well.
> 
> --- a/libavcodec/mpegvideo_enc.c
> +++ b/libavcodec/mpegvideo_enc.c
> @@ -2984,7 +2984,7 @@ static int encode_picture(MpegEncContext *s, int picture_number)
>  
> -void  denoise_dct_c(MpegEncContext *s, DCTELEM *block){
> +static void denoise_dct_c(MpegEncContext *s, DCTELEM *block){
>      const int intra= s->mb_intra;
>      int i;
>  
> @@ -3008,9 +3008,9 @@ void  denoise_dct_c(MpegEncContext *s, DCTELEM *block){
>  
> -int dct_quantize_trellis_c(MpegEncContext *s,
> -                        DCTELEM *block, int n,
> -                        int qscale, int *overflow){
> +static int dct_quantize_trellis_c(MpegEncContext *s,
> +                                  DCTELEM *block, int n,
> +                                  int qscale, int *overflow){
>      const int *qmat;
>      const uint8_t *scantable= s->intra_scantable.scantable;
>      const uint8_t *perm_scantable= s->intra_scantable.permutated;

OK

I have a slight preference for folding this and Flameeyes' patch into
one commit.

Diego



More information about the ffmpeg-devel mailing list