[FFmpeg-devel] [PATCH 04/11] Make ff_mxf_pixel_layouts static to mxf.c.

Janne Grunau janne-ffmpeg
Tue Jan 25 21:26:40 CET 2011


On Mon, Jan 24, 2011 at 09:51:16PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Jan 24, 2011 at 8:29 PM, Diego Elio Petten? <flameeyes at gmail.com> wrote:
> > Also make it an anonymous structure as never it is accessed by name.
> > ---
> > ?libavformat/mxf.c | ? ?5 ++++-
> > ?libavformat/mxf.h | ? ?7 -------
> > ?2 files changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/libavformat/mxf.c b/libavformat/mxf.c
> > index c7423b0..643a952 100644
> > --- a/libavformat/mxf.c
> > +++ b/libavformat/mxf.c
> > @@ -52,7 +52,10 @@ const MXFCodecUL ff_mxf_codec_uls[] = {
> > ? ? { { 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00 }, ?0, ? ? ? CODEC_ID_NONE },
> > ?};
> >
> > -const MXFPixelLayout ff_mxf_pixel_layouts[] = {
> > +static const struct {
> > + ? ?enum PixelFormat pix_fmt;
> > + ? ?const char data[16];
> > +} ff_mxf_pixel_layouts[] = {
> 
> Looks OK to me, but please lose the ff_ part.

ok and queued

Janne



More information about the ffmpeg-devel mailing list