[FFmpeg-devel] [PATCH] emulated_edge #2
Wed Jan 26 09:04:02 CET 2011
On 25 January 2011 23:29, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> On Tue, Jan 25, 2011 at 4:42 PM, Rob <robert.swain at gmail.com> wrote:
>> On 25 January 2011 19:48, Jason Garrett-Glaser <jason at x264.com> wrote:
>>> On Mon, Jan 24, 2011 at 9:20 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>>>> rough version of version #2 of this patch. Brief:
>>>> old(c): 7820 dezicycles in emu_edge, 1047850 runs, 726 skips
>>>> new(c): 5511 dezicycles in emu_edge, 1048056 runs, 520 skips
>>>> x86-32(mmx): 2080 dezicycles in emu_edge, 1048345 runs, 231 skips
>>>> x86-64(sse): 1723 dezicycles in emu_edge, 1048327 runs, 249 skips
>>> This is fucking ugly but very cool, concept LGTM, I'm not going to
>>> whine too hard about the code.
>> Are there any low-hanging fruit for improvements? Ronald, are you
>> rather putting it out there for kicks or really intending it for
>> inclusion? I haven't looked at it and don't know the code, just
>> Jason's response makes me think perhaps it's not ready for
> I won't commit the asm yet. The C code and DSPContext interface is
> fine, what's needed is some cleanup of the ASM code. I'll do that in
> the next few days, resubmit for review and if OK, commit that.
> The code is somewhat ugly and that's exactly what I plan to fix. The
> code itself won't change (binary identical), just prettier source.
More information about the ffmpeg-devel