[FFmpeg-devel] [PATCH] In video_thread(), disable logging of rescaled timestamps if DEBUG is not enabled.

Måns Rullgård mans
Sat Jan 29 14:53:06 CET 2011


Luca Barbato <lu_zero at gentoo.org> writes:

> On 01/29/2011 11:46 AM, Diego Biurrun wrote:
>> IIRC (but I may well be wrong) the ff* tools do use internal symbols in
>> other places.  Another option is to make the symbol or some variant of
>> it public.
>
> They should not. We have already not many examples and we shouldn't
> suggest wrong (and soon-broken) behaviours.
>
>>> Also it conflicts with the dprintf defined in stdio.h.
>> 
>> This is of course bad, but such a name clash should be addressed in
>> FFmpeg anyway.  We can just rename it to dbg_printf, ff_dprintf or
>> similar.
>
> Agreed.

For public exposure, I nominate av_dlog().

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list