[FFmpeg-devel] [PATCH] lavf: inspect more frames when the time base is unreliable

Michael Niedermayer michaelni
Sat Jan 29 16:57:00 CET 2011

On Sat, Jan 29, 2011 at 02:35:02PM +0000, M?ns Rullg?rd wrote:
> >>> and the timings simply can't be estimated correctly in just 20
> >>> frames by the current algorithm with only millisecond-precision
> >>> timestamps.
> >> 
> >> Nor should they.  The frame duration from the header should be used.
> >
> > Well, I see that for normal non-MPEG2/non-H264 files we use the
> > framerate calculated from the codec time base (as below). Do you think
> > using that would be ok for H.264 as well (at least if the first 5 or so
> > timestamps seem to match that value, assuming H264 is considered
> > unreliable for a reason), or if we should add some new case for using
> > the format headers instead.
> >
> > For the files in question the codec time base shows an fps of 24/1.001
> > exactly.
> So the container header is correct, the elementary stream header is
> correct, and lavf still manages to arrive at a wrong value.  Well done!

improve it please without breaking more cases than are currently broken.
then brag about it being shit

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110129/d603e556/attachment.pgp>

More information about the ffmpeg-devel mailing list