[FFmpeg-devel] [PATCH] movie video source

Michael Niedermayer michaelni
Sun Jan 30 16:15:10 CET 2011

On Sun, Jan 30, 2011 at 12:32:25AM +0100, Stefano Sabatini wrote:
> +    if (movie->seek_point_d > (INT64_MAX-0.5) / 1000000) {
> +        av_log(ctx, AV_LOG_ERROR, "Value for seek point is too big\n");
> +        return AVERROR(EINVAL);
> +    }

i think you can set the max in the AVOptions table correctly

except that lgtm if tested

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110130/5158f086/attachment.pgp>

More information about the ffmpeg-devel mailing list