[FFmpeg-devel] [PATCH] Implement guessed_pts in avcodec_decode_video2.

Måns Rullgård mans
Mon Jan 31 00:05:26 CET 2011


Luca Barbato <lu_zero at gentoo.org> writes:

> On 01/30/2011 09:51 PM, M?ns Rullg?rd wrote:
>> Either you have the timestamps and should consider them reliable, or
>> you do not, and will have to extrapolate using frame rate.  The only
>> unreliable timestamps here are the ones lavf invents out of thin air.
>> If that nonsense were removed, this hack could probably go away at the
>> same time.  The timestamp handling is currently ugly hack piled upon
>> uglier hack finished off with a few dirty workarounds.  It needs to be
>> fixed, not merely shuffled around to fit the phase of the moon.
>
> I think we could try a branch with all those removed and run it over our
> samples collection.
>
> If the strict ffmpeg survives as well as the guessing ffmpeg then we
> could decide.
>
> I don't see much to discuss beside that ^^;

I suspect many of our test references have wrong timestamps.  Any
tests that differ would need to be examined one by one.  Same goes for
the larger samples collection.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list