[FFmpeg-devel] [PATCH] Ogg: discard non-essential metadata from Vorbis header when creating extradata.
Mon Jan 31 21:23:37 CET 2011
Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> On Mon, Jan 31, 2011 at 06:30:02PM +0000, M?ns Rullg?rd wrote:
>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>> > What would be the point of a realloc besides wasting CPU time?
>> > The point is that priv->len is smaller and thus the amount
>> > of data that is copied into extradata is smaller.
>> > I can't imagine we have to optimize for a few 100 kB during header
>> > parsing.
>> You're right of course. I overlooked the second copying. Please send
>> a properly formatted patch and we'll apply it.
> I'd do that more often if I had an efficient way to make git work
> with a mail-client instead of it trying to be (a really sucky) one.
> The idiocy of having the commit message in the subject line will
> probably reliably prevent that though.
You may attach patches created with git format-patch if you prefer.
That's no more or less work than creating diffs with svn.
> The first part of the metadata, the "vendor" string, is required by
> libvorbis, it will refuse to play when it is not available.
> Also we do not currently parse that part into metadata so it would also
> be lost if we removed it as well.
> libavformat/oggparsevorbis.c | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
mans at mansr.com
More information about the ffmpeg-devel