[FFmpeg-devel] [RFC] av_get_bits_per_sample() questions

Stefano Sabatini stefano.sabatini-lala at poste.it
Sun Jun 5 22:28:22 CEST 2011


On date Sunday 2011-03-13 17:27:24 -0400, Justin Ruggles wrote:
> On 03/13/2011 05:24 PM, Alex Converse wrote:
> 
> > On Sun, Mar 13, 2011 at 2:20 PM, Justin Ruggles
> > <justin.ruggles at gmail.com> wrote:
> >> On 03/13/2011 04:59 PM, Stefano Sabatini wrote:
[...]
> >>> The second one, av_get_bits_per_sample_fmt(), is misnamed (should be
> >>> av_get_bits_per_sample()), so we may change the name to
> >>> av_get_bits_per_sample2() for avoiding the conflict with the name
> >>> already taken.
> >>
> >>
> >> I agree.  But as long as we're reworking it, why not
> >> av_get_bytes_per_sample() so it doesn't have to be divided by 8 everywhere?
> >>
> > 
> > Don't some ADPCM codecs have less than 8 bits per sample.

First variant attached, if we have no reasons to in the future we
won't add some sample format with a non integer number of bytes then
I'll post the av_get_bytes_per_sample() variant.
-- 
<RoboHak> hmm, lunch does sound like a good idea
<Knghtbrd> would taste like a good idea too
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samplefmt-add-av_get_bits_per_sample2.patch
Type: text/x-diff
Size: 2769 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110605/11b2968d/attachment.bin>


More information about the ffmpeg-devel mailing list