[FFmpeg-devel] [libav-devel] [PATCH] Change behviour of empty AVFilterFormats lists

Mina Nagy Zaki mnzaki at gmail.com
Wed Jun 8 01:21:45 CEST 2011

On Wednesday 08 June 2011 02:55:53 Stefano Sabatini wrote:
> > From: Mina Nagy Zaki <mnzaki at gmail.com>
> > Date: Tue, 7 Jun 2011 17:43:30 +0300
> > Subject: [PATCH 2/2] lavfi: Make an empty AVFilterFormats mean 'all
> > formats'
> > 
> >  supported.
> > 
> > This makes avfilter_all_formats unnecessary, and so it was removed.
> I have to confess that I don't like this change. Indeed to me "empty
> formats list" has a different meaning than "list containing all
> supported formats", and at least for me it's making harder to
> understand the code.
> Also there are some cases (e.g. the noformat filter), where it makes
> sense to actually return an empty list which means "an empty list".
> So I'd prefer to see the following patches before to judge.
> [...]

It's not actually that important to the following patches, it just simplifies 
things. I just looked at vf_noformat, and I see what you mean, it needs an 
explicit list of formats. But this patch doesn't disallow explicit 'all 
formats' lists really. I guess it's just me worrying about all the extra 
allocated bytes :P bad habits die hard.


More information about the ffmpeg-devel mailing list