[FFmpeg-devel] [PATCH] resample: clarify supported resampling.
ubitux at gmail.com
Sat Jun 11 15:11:17 CEST 2011
On Thu, Jun 09, 2011 at 01:43:05AM +0200, Michael Niedermayer wrote:
> On Wed, Jun 08, 2011 at 11:48:03AM +0200, Clément Bœsch wrote:
> > Hi,
> > The attached patch should clarify a bit the audio resampling support.
> > Please check if I didn't forget any support; it seems the current error
> > message omit for example the downmix from 6 to 2 channels.
> > Additionally, the patch fix a sigsegv when requesting 2 channels output
> > with 8 channels input.
> > Just a question: all the downmix could be supported with a generic code
> > somewhat easily; why isn't it done? Is there any special reason?
> > Also, the resampling API seems inconsistent (and not very usable for a
> > user), can anyone enlighten me on what is planed on that matter?
> > Regards,
> > : http://www-mmsp.ece.mcgill.ca/documents/audioformats/wave/Samples/Microsoft/8_Channel_ID.wav
> > --
> > Clément B.
> > resample.c | 29 ++++++++++++++++++++++++-----
> > 1 file changed, 24 insertions(+), 5 deletions(-)
> > 94b7fa4841c258541672b2120f089bd2f6c0a3a2 0001-resample-clarify-supported-resampling.patch
> > From b141cc99e951e0a4e8fba11b9ce3f9002ea20f80 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <clement.boesch at smartjog.com>
> > Date: Wed, 8 Jun 2011 11:26:43 +0200
> > Subject: [PATCH] resample: clarify supported resampling.
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> > This also fix a crash on 8ch → 2ch requested resampling.
> should be ok if tested
re-tested and pushed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 490 bytes
Desc: not available
More information about the ffmpeg-devel