[FFmpeg-devel] [PATCH] lavfi: add vsink_buffer, and use it in ff* tools
stefano.sabatini-lala at poste.it
Sun Jun 19 20:18:29 CEST 2011
On date Wednesday 2011-06-15 13:40:34 +0200, Stefano Sabatini encoded:
> On date Wednesday 2011-06-15 05:15:40 +0200, Michael Niedermayer encoded:
> > On Tue, Jun 14, 2011 at 01:32:21PM +0200, Stefano Sabatini wrote:
> > > On date Monday 2011-06-13 00:27:39 +0200, Stefano Sabatini encoded:
> > > > On date Sunday 2011-06-12 17:32:37 +0200, Michael Niedermayer encoded:
> > > [...]
> > > > Not pushed, there is a small leak problem (when uniting the sink
> > > > inlink->cur_buf may still contain a picref, but inlink was already
> > > > freed. So we need either to unref the picref when freeing the link, or
> > > > cache the picref in the sink context, so we can free it in uninit) but
> > > > I'm too tired now to decide which is the better solution.
> > > >
> > > > Patch updated with docs.
> > >
> > > I'm caching the picref in the sink itself, I'm keeping just one frame
> > > for the moment, this could be improved by increasing the size of the
> > > cache (which is even required by some scenario, e.g. with a split
> > > filter).
> > >
> > > Check attached patch.
> > ive not had the time to fully review this but if it works and adds
> > no new limitations then it should be ok
> I'll do soon if I see no more comments.
FFmpeg = Fantastic and Fascinating Maxi Patchable Erudite Generator
More information about the ffmpeg-devel