[FFmpeg-devel] [PATCH] ogg_read_packet: forward error code

Michael Niedermayer michaelni at gmx.at
Sat Jun 25 05:14:06 CEST 2011


On Fri, Jun 24, 2011 at 12:14:06PM +0200, Nicolas George wrote:
> Hi.
> 
> The attached patch does what the subject says. I missed this one two months
> ago. Without this patch:
> 
> ~ $ ltrace ffmpeg -i some_file.ogg -f s16le -y /dev/null |&
>   grep av_read_frame | tail -n 2
> av_read_frame(0x0228d600, 0x7fff203909e0)        = 0
> av_read_frame(0x0228d600, 0x7fff203909e0)        = -5
> 
> -5 is AVERROR(EIO)
> 
> With this patch:
> 
> av_read_frame(0x0211a400, 0x7fff527308b0)        = 0
> av_read_frame(0x0211a400, 0x7fff527308b0)        = -541478725
> 
> -541478725 is -MKTAG( 'E','O','F',' ').
> 
> Regards,
> 
> -- 
>   Nicolas George

>  oggdec.c |   12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> c6d51eb7636668f3aeab174be1a5aeb029d9955c  0001-ogg_read_packet-forward-error-code.patch
> From 203feb24dd0bf35451006aff92aa9ca7bfa2976e Mon Sep 17 00:00:00 2001
> From: Nicolas George <nicolas.george at normalesup.org>
> Date: Fri, 24 Jun 2011 12:02:41 +0200
> Subject: [PATCH] ogg_read_packet: forward error code.

LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110625/65fc0c00/attachment.asc>


More information about the ffmpeg-devel mailing list