[FFmpeg-devel] swscale merge

Ronald S. Bultje rsbultje at gmail.com
Thu Jun 30 05:56:13 CEST 2011


Hi,

On Wed, Jun 29, 2011 at 8:23 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> +static void lumRangeToJpeg16_c(int16_t *_dst, int width)
> +{
> +    int i;
> +    int32_t *dst = (int32_t *) _dst;
>              ^^^^^^^^^^^^^^^^^^
> undefined behavior (aliasing violation)

No.

> +    for (i = 0; i < width; i++)
> +        dst[i] = (FFMIN(dst[i],30189)*19077 - 39057361)>>14;
>                                ^^^^^
> clips the 32bit values incorrectly

Fixed (roughly).

>                                                       ^^^^^
> overflows

No.

Ronald


More information about the ffmpeg-devel mailing list