[FFmpeg-devel] [PATCH] source snapshots back in action since a long time

Ivan Kalvachev ikalvachev
Wed Mar 2 00:16:48 CET 2011

On 3/2/11, Diego Biurrun <diego at biurrun.de> wrote:
> On Tue, Mar 01, 2011 at 09:46:33PM +0100, Reimar D?ffinger wrote:
>> On Tue, Mar 01, 2011 at 09:43:02PM +0100, Reimar D?ffinger wrote:
>> > > > Ronald S. Bultje <rsbultje <at> gmail.com> writes:
>> > > >
>> > > >> You are not exempt from the patch-posting and
>> > > >> review rules that apply to all of us.
>> >
>> > A patch was posted and a review was done, so your statement
>> > as such makes no sense.
>> And I forgot to say that also nobody ever said anything about
>> the rules for the homepage SVN.
> That's why I sent a patch instead of committing directly, I was
> taking the defensive and cautious route.
>> While Diego mentioned a valid reason for complaints, claiming
>> rules does not seem like more than a cheap excuse at making it
>> sound more fact-based objection than it is.
> Sorry, but this is nonsense.  It took CE less than 15 minutes to
> apply a patch that Michael posted quickly to beat me at adding
> git snapshot information to the homepage.

I don't think we are on sprint race here.

> It was perfectly clear that this would be highly controversial to
> say the least, so the only objective of that stunt was provocation,
> nothing else.  You know that as well as I do.

Look, you have sent patch. There was a mistake in your patch.
You said you have fixed it locally but you haven't resubmitted the
correct version to the maillist. It got approved anyway.

May I ask who is really the controversial one?

On a side note.

There is a little shortcoming that pop ups here. I think it could be fixed
if patches are applied by the person who does the review and accepts the patch.

This have the following benefits:
1. Make the commit faster.
2. Sign-off the commit with the name of the reviewer. Now, you can't
say who approved the commiters patches just by looking in -commits
maillist. You see the same name for author and sign-off. To find out
the reviewer you must search in -devel.
3. Ensure that the committed patch is the one sent to the maillist.

More information about the ffmpeg-devel mailing list