[FFmpeg-devel] [PATCH] aviobuf: Write new data at s->buf_end in fill_buffer

Luca Barbato lu_zero
Wed Mar 2 11:19:49 CET 2011

On 03/01/2011 10:12 PM, Michael Niedermayer wrote:
> On Sun, Feb 27, 2011 at 01:02:32AM +0200, Martin Storsj? wrote:
>> In most cases, s->buf_ptr will be equal to s->buf_end when
>> fill_buffer is called, but this may not always be the case, if
>> we're seeking forward by reading (permitted by the short seek
>> threshold).
>> If fill_buffer is writing to s->buf_ptr instead of s->buf_end (when
>> they aren't equal and s->buf_ptr is ahead of s->buffer), the data
>> between s->buf_ptr and s->buf_end is overwritten, leading to
>> inconsistent buffer content. This could return incorrect data if
>> later seeking back into the area before the current s->buf_ptr.
>> ---
>>  libavformat/aviobuf.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
> looks ok

Queue and pushed now.



Luca Barbato

More information about the ffmpeg-devel mailing list