[FFmpeg-devel] [FFmpeg-commits] lavf: replace all uses of url_fskip with avio_seek
Wed Mar 2 20:49:09 CET 2011
On 3/2/11 10:51 AM, M?ns Rullg?rd wrote:
> Luca Barbato <lu_zero at gentoo.org> writes:
>> On 03/02/2011 07:13 PM, Reimar D?ffinger wrote:
>>> Most of the code is essentially unchanged from a time when choosing the wrong
>>> one would break things.
>>> fskip will have been used for short seeks that would not cause issues with
>>> non-seekable or badly seekable streams like stdin and http, fseek for
>>> cases where you have given up on that.
>> That should had been in doxy, was it?
>>> As such the distinction served as a documentation at least.
>> I guess it hadn't been much effective. =\
> Regardless of intentions, the functions were exactly the same, skip()
> simply calling seek(SEEK_CUR). Having two ways of doing exactly the
> same thing is always bad.
I don't agree with this.
url_fskip has one less parameter and is _convenient_ from a developer
point of view, the same applies to avio_write which forces the dev to
write nonsensical things like:
avio_write(pb, "test", strlen("test")-1);
More than one developper is not happy with these changes, and I don't
think it was a good change.
Furthermore, it seems API changes are made way too faster before anybody
can raise concerns.
Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer http://www.ffmpeg.org
More information about the ffmpeg-devel