[FFmpeg-devel] [PATCH] movenc.c: fix metadata writing.

Måns Rullgård mans
Fri Mar 4 03:51:57 CET 2011

"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Fix metadata writing, broken in commit:
> 0abdb2931719d96dee725e555e9b46b2b2f8a6be
> because some characters in the string are >=0x80 and therefore the
> shift on characters in the fourcc broke down because of sign extension.

Wouldn't it be better to fix those shifts?

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list