[FFmpeg-devel] [PATCH] avio: deprecate url_feof
Mon Mar 7 23:43:39 CET 2011
On Mon, Mar 07, 2011 at 05:34:10PM -0500, Ronald S. Bultje wrote:
> On Mon, Mar 7, 2011 at 5:31 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Mon, Mar 07, 2011 at 05:29:14PM -0500, Ronald S. Bultje wrote:
> >> On Mon, Mar 7, 2011 at 5:22 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Mon, Mar 07, 2011 at 09:50:25PM +0100, Anton Khirnov wrote:
> >> >> AVIOContext.eof_reached should be used directly instead.
> >> >
> >> > If you are at eof, and some other process (wget?) appends to the file
> >> > url_feof() could return 0 again. with direct access this is harder
> >> url_feof() reutrns s->eof_reached??
> > you can put something else in there like
> > if(protocol.check_eof()) return protocol.check_eof();
> Right, but that wasn't there for the past 5 years, so it's likely OK.
the API hasnt changed in 5 years and so its ok to make it worse?
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel