[FFmpeg-devel] [PATCH 3/3] ac3enc: add SIMD-optimized shifting functions for use with the fixed-point AC3 encoder

Justin Ruggles justin.ruggles
Wed Mar 9 18:57:19 CET 2011

On 03/08/2011 05:59 PM, Ronald S. Bultje wrote:

> Hi,
> On Tue, Mar 8, 2011 at 4:19 PM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de> wrote:
>> jg would incorrectly exit immediately for lend >= 2^31 (since lend would then be negative interpreted as signed value and certainly not larger than mmsize*2).
> [..]
>> +static void ac3_shift_int32_c(int32_t *src, int len, int shift)
> len is signed.

hmmm. I'll change it to unsigned.  The function constraints already say
it needs to be greater than 0, and it's treated as unsigned.


More information about the ffmpeg-devel mailing list