[FFmpeg-devel] Patch review request: 10bit DNxHD decoding support

Stefan Gehrer stefan.gehrer
Thu Mar 10 18:51:26 CET 2011

On 03/10/2011 05:36 PM, Joseph Artsimovich wrote:
> Hi,
> At this point I am happy with my patch adding support for decoding 10bit DNxHD, apart from poor performance due to the lack of assembly optimized IDCT code that can handle 10bit samples.  Please review and give feedback.

@@ -39,8 +40,16 @@ typedef struct {
      int cur_field;                      ///< current interlaced field
      VLC ac_vlc, dc_vlc, run_vlc;
      int last_dc[3];
-    DSPContext dsp;
+    /* It easier to have both DSPs always initialized than initialize one
+       on demand. Note that these DSPs may have different permutation 
tables. */
+    DSPContext dsp8;
+    DSPContext dsp10;
+    DSPContext* dsp;

I think you should avoid having DSPContext twice. If you really need
8bit and 10bit decoding in the same file or stream, you could just
add a second permutation table within DSPContext, one for the 8bit
IDCT as is and the other for the 10bit IDCT.


More information about the ffmpeg-devel mailing list