[FFmpeg-devel] [PATCH] cmdutils: change signature to list_fmts()

Stefano Sabatini stefano.sabatini-lala
Sat Mar 12 13:11:08 CET 2011

On date Saturday 2011-03-12 12:03:04 +0000, M?ns Rullg?rd encoded:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> Why is this implemented in this way anyway?  It is only used in once
> place, so passing function pointers around seems unnecessary.

It was used in two distinct places (opt_frame_pix_fmt and
opt_sample_fmt), then the first use was replaced by show_pix_fmts(),
which access some information exposed by libswscale.

A more consistent solution would be:

and have:
-pix_fmt    list use av_get_pix_fmt_string()
-sample_fmt list use av_get_sample_fmt_string()

or eventually drop -pix_fmt/-sample_fmt list.
FFmpeg = Fostering and Frenzy Miracolous Peaceful Elfic Game

More information about the ffmpeg-devel mailing list