[FFmpeg-devel] [PATCH] ac3dec: avoid pointless alloc and indirection for input_buffer

Michael Niedermayer michaelni at gmx.at
Fri Mar 25 19:33:21 CET 2011

On Fri, Mar 25, 2011 at 07:02:36PM +0100, Reimar Döffinger wrote:
> On Fri, Mar 25, 2011 at 01:25:58AM +0100, Michael Niedermayer wrote:
> > On Thu, Mar 24, 2011 at 09:29:27PM +0100, Reimar Döffinger wrote:
> > > Since we now always allocate it,
> > 
> > Note, i do not consider this a good idea, we have things like a fast
> > flag based upon which the copy could be skiped
> I think we'd really need a new flag, I don't think it's acceptable
> to use that fast flag for stuff that might cause crashes.

iam not sure if it cant crash already elsewhere with fast

> > > it can simply be made part of the context
> > > instead.
> > 
> > missing alignment otherwise LGTM
> I don't want to insist really.
> I'm going to send an updated patch, but I'd rather leave it to the
> maintainer to decide.

of course

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110325/2ea884d0/attachment.asc>

More information about the ffmpeg-devel mailing list