[FFmpeg-devel] [PATCH] Fix check for new enough CrystalHD library

Michael Niedermayer michaelni at gmx.at
Mon Mar 28 20:52:57 CEST 2011

On Mon, Mar 28, 2011 at 11:34:38AM +0200, Gwenole Beauchesne wrote:
> Hi,
> If an older libcrystalhd is installed, the current configure check will  
> validate it but will fail to build FFmpeg since there were some API  
> changes.
> I see two ways to check this:
> 1) Check for the new libcrystalhd_version.h file
> 2) Check for the new DtsCrystalHDVersion() function
> (2) is implemented in the attached patch. Along with an addition to make  
> sure crystalhd support is disabled if check_lib fails.
> Regards,
> Gwenole.

>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 17ca14a57c6e75e3af2c728c58b8dbe79c53cc0a  0002-Fix-check-for-new-enough-CrystalHD-library.patch
> From 1a45b809f6eb2f48385f8cfb5ceca3b8c5471d90 Mon Sep 17 00:00:00 2001
> From: Gwenole Beauchesne <gbeauchesne at splitted-desktop.com>
> Date: Mon, 28 Mar 2011 10:18:58 +0200
> Subject: [PATCH] Fix check for new enough CrystalHD library.

Philip? you are/(should be) maintainer of the CrystalHD stuff

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110328/f6675f85/attachment.asc>

More information about the ffmpeg-devel mailing list