[FFmpeg-devel] postprocess.c: filter name needs to be double 0 terminated
michaelni at gmx.at
Sun May 29 00:15:03 CEST 2011
On Sat, May 28, 2011 at 10:22:34PM +0200, Michael Niedermayer wrote:
> On Sat, May 28, 2011 at 07:24:41PM +0200, Piotr Kaczuba wrote:
> > Since the switch from strncpy() to av_strlcpy() in
> > pp_get_mode_by_name_and_quality() in libpostproc/postprocess.c (commit
> > 1a5e4fd8c5b99478b4e08a69261930bb12aa948b), the replacement of short
> > filter names doesn't work any more. The way the replacement algorithm
> > works, it requires that the whole filter name string be double 0
> > terminated. Strncpy() took care of that quasi automatically by filling
> > the remainder of the buffer with zeroes, but av_strlcpy() does not. In
> > the case of mplayer, the error message is:
> > $ mplayer -vf pp a.avi
> > ...
> > Opening video filter: [pp]
> > 1 errors in postprocess string "de"
> > ...
> > Attached patch fixes it.
> > --
> > Cheers,
> > Piotr
> > postprocess.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> > 8b38d13cb2d1fe73b25d2bf4f7e664f0cada33f3 postprocess.diff
> applied, thx
not pushed, it failed tests, the code needs more bytes to be 0 than 2
when multiple expansions happen
i reverted the problematic hunk that caused all this locally
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel