[FFmpeg-devel] [PATCH] gxf: add timecode information to metadata

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Nov 1 08:25:12 CET 2011

On 31 Oct 2011, at 23:54, Matthieu Bouron <matthieu.bouron at gmail.com> wrote:
> 2011/10/31 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
>> Also note that by merging the new tlen and tag checks into a single
>> if you can avoid duplicating the skip case.
>> I can make these changes myself if you get tired of those nits,
>> though I don't have any sample to test it on, so it seems easier
>> to leave it to you.
> No problem, i updated the patch. Hope it will be ok this time.
> <0001-gxf-add-timecode-information-to-metadata.patch>

Looks good. I don't have the spec at hand, can you tell me the meaning of the track types you check for? I might want to add a comment there.
I'll try to test and push this evening (European time).

More information about the ffmpeg-devel mailing list