[FFmpeg-devel] [PATCH] audioconvert: prefer 5.X over 5.X(side).
michaelni at gmx.at
Sun Nov 6 17:07:53 CET 2011
On Sun, Nov 06, 2011 at 11:45:21AM +0100, Stefano Sabatini wrote:
> On date Sunday 2011-11-06 11:16:45 +0100, Nicolas George encoded:
> > This is the logical consequence of commit ab539d9e:
> > 5.X(back) is more common than 5.X(side).
> > Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> > ---
> > libavutil/audioconvert.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> > Stefano:
> > > Why? => possibly explain it in the log.
> > Is it better? For reference:
> > # commit ab539d9eb88dd20e6d5409464d74a899a507a3dd
> > # Author: Carl Eugen Hoyos <cehoyos at ag.or.at>
> > # Date: Sun Aug 28 22:37:11 2011 +0200
> > #
> > # Use the shorter channel layout description for the common case.
> Yep, indeed I remembered that change, thanks.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel